[lworld] RFR: 8354728: [lworld] Langtools work to update strict implementation to latest [v3]

[Chen Liang]

On Sun, 27 Apr 2025 02:39:05 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into feature/unset-update
>>  - Tweaks to let tests pass
>>  - Chen comment
>>  - 8354694: [lworld] Refactor AssertUnsetFields to Early Larval Frame
>>  - Review suggestions, also rollback the getEntryType rename in javac, test updates
>>  - 8354728: [lworld] Langtools work to update strict implementation to latest
>
> src/java.base/share/classes/jdk/internal/classfile/impl/CodeImpl.java line 301:
> 
>> 299:                         continue;
>> 300:                     }
>> 301:                     case 247 -> {
> 
> Although not related to this PR, why is it that only StackMapDecoder.EARLY_LARVAL uses constants, but the others use magic numbers?

We periodically merge from mainline JDK. These are in mainline; we don't want to create redundant merge conflicts. There is a mainline bug entry for this, feel free to contribute: https://bugs.openjdk.org/browse/JDK-8354871

I think such a contribution will be more welcomed by other reviewers compared to domain-specific optimizations.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1432#discussion_r2061963357