[lworld] RFR: 8354728: [lworld] Langtools work to update strict implementation to latest [v3]
Shaojin Wen
swen at openjdk.org
Sun Apr 27 02:54:59 UTC 2025
On Sat, 26 Apr 2025 17:38:13 GMT, Chen Liang <liach at openjdk.org> wrote:
>> The updates to the core libraries + langtools for the latest strict field initialization spec https://cr.openjdk.org/~dlsmith/jep401/jep401-20250409/specs/strict-fields-jvms.html is ready.
>>
>> Currently, since there is no VM support, testing is restricted to generation by ClassFile API/javac and inspection through ClassFile API (and javap)
>>
>> Not suitable for integration yet; StrictFinalInstanceFieldsTest requires VM side's support.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into feature/unset-update
> - Tweaks to let tests pass
> - Chen comment
> - 8354694: [lworld] Refactor AssertUnsetFields to Early Larval Frame
> - Review suggestions, also rollback the getEntryType rename in javac, test updates
> - 8354728: [lworld] Langtools work to update strict implementation to latest
src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line 1268:
> 1266: if (debugstackmap) System.out.print(" " + i + ":");
> 1267: StackMapTableFrame frame = code.stackMapTableBuffer[i];
> 1268: frame.write(this);
code.stackMapTableBuffer[i].write(this);
This variable is only used once, can it be removed?
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1432#discussion_r2061965442
More information about the valhalla-dev
mailing list