[lworld] RFR: 8354728: [lworld] Langtools work to update strict implementation to latest [v3]

Chen Liang liach at openjdk.org
Sun Apr 27 03:08:03 UTC 2025


On Sun, 27 Apr 2025 02:51:58 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into feature/unset-update
>>  - Tweaks to let tests pass
>>  - Chen comment
>>  - 8354694: [lworld] Refactor AssertUnsetFields to Early Larval Frame
>>  - Review suggestions, also rollback the getEntryType rename in javac, test updates
>>  - 8354728: [lworld] Langtools work to update strict implementation to latest
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line 1268:
> 
>> 1266:                 if (debugstackmap) System.out.print("  " + i + ":");
>> 1267:                 StackMapTableFrame frame = code.stackMapTableBuffer[i];
>> 1268:                 frame.write(this);
> 
> code.stackMapTableBuffer[i].write(this);
> 
> This variable is only used once, can it be removed?

This patch is made by IDE during renames. The patch here is incomplete; we might have a complete patch when value objects jep has its pull request, I think.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1432#discussion_r2061974401


More information about the valhalla-dev mailing list