[lworld] RFR: 8354728: [lworld] Langtools work to update strict implementation to latest [v3]

[Roger Riggs]

On Sat, 26 Apr 2025 17:38:13 GMT, Chen Liang <liach at openjdk.org> wrote:

>> The updates to the core libraries + langtools for the latest strict field initialization spec https://cr.openjdk.org/~dlsmith/jep401/jep401-20250409/specs/strict-fields-jvms.html is ready.
>> 
>> Currently, since there is no VM support, testing is restricted to generation by ClassFile API/javac and inspection through ClassFile API (and javap)
>> 
>> Not suitable for integration yet; StrictFinalInstanceFieldsTest requires VM side's support.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into feature/unset-update
>  - Tweaks to let tests pass
>  - Chen comment
>  - 8354694: [lworld] Refactor AssertUnsetFields to Early Larval Frame
>  - Review suggestions, also rollback the getEntryType rename in javac, test updates
>  - 8354728: [lworld] Langtools work to update strict implementation to latest

Looks ok, though I don't have much experience with javac.

src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 372:

> 370: 
> 371:     /**
> 372:      * The access flag {@code ACC_STRICT_INIT}, with a mask

Is the reference Modifier#STRICT still relevant?
The description in java.lang.Modifier is obsolete for JDK 25 (and some previous versions).
It could be expanded to cover the release specific cases. 
The Modifier.isStrict() method is also dated.  Maybe that's a separate issue.

-------------

PR Review: https://git.openjdk.org/valhalla/pull/1432#pullrequestreview-2799669877
PR Review Comment: https://git.openjdk.org/valhalla/pull/1432#discussion_r2063883626