[lworld] RFR: 8354728: [lworld] Langtools work to update strict implementation to latest [v3]

Chen Liang liach at openjdk.org
Mon Apr 28 16:08:03 UTC 2025


On Mon, 28 Apr 2025 15:11:09 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into feature/unset-update
>>  - Tweaks to let tests pass
>>  - Chen comment
>>  - 8354694: [lworld] Refactor AssertUnsetFields to Early Larval Frame
>>  - Review suggestions, also rollback the getEntryType rename in javac, test updates
>>  - 8354728: [lworld] Langtools work to update strict implementation to latest
>
> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 372:
> 
>> 370: 
>> 371:     /**
>> 372:      * The access flag {@code ACC_STRICT_INIT}, with a mask
> 
> Is the reference Modifier#STRICT still relevant?
> The description in java.lang.Modifier is obsolete for JDK 25 (and some previous versions).
> It could be expanded to cover the release specific cases. 
> The Modifier.isStrict() method is also dated.  Maybe that's a separate issue.

Indeed; should I change the value rendering to `{@code}` like that for INTERFACE to prevent misleading links?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1432#discussion_r2064005892


More information about the valhalla-dev mailing list