[lworld] RFR: 8360851: [lworld] missing # {method} comment in assembly dumping [v2]
Manuel Hässig
mhaessig at openjdk.org
Thu Aug 21 11:26:54 UTC 2025
> `CodeOffsets::Verified_Inline_Entry` and `CodeOffsets::Verified_Inline_Entry` are special among entry point code offsets because they can be disabled with a value of `-1`. The code installation for hotspot deals with this by just setting both to the same value as `CodeOffsets::Verified_Entry` if they are disabled. JVMCI code installation on the other hand, leaves the offsets at `-1`. When printing the assembly of a JVMCI compiled method where both offsets are disabled, the method name is not printed together with the entry point labels. This is due to the disabled entry points having the lowest address due to their negative offset and those disabled entry points thus pointing to an address before the block that is being printed:
>
> https://github.com/openjdk/valhalla/blob/af03598eb81aee17c0657347fd6439475ca8f7ee/src/hotspot/share/code/nmethod.cpp#L3788-L3796
>
> This PR fixes this issue by checking if the entry points that can be disabled point into the code block that is being printed. The regression test is botched together from two existing tests, due to my inexperience with JVMCI (but it works). Suggestions for a better test are welcome.
>
> Testing:
> - [x] tier1,tier2,tier3,valhalla-comp-stress
Manuel Hässig has updated the pull request incrementally with one additional commit since the last revision:
Problem list regression test for ZGC on aarch64
-------------
Changes:
- all: https://git.openjdk.org/valhalla/pull/1529/files
- new: https://git.openjdk.org/valhalla/pull/1529/files/32d097bd..4fd05be3
Webrevs:
- full: https://webrevs.openjdk.org/?repo=valhalla&pr=1529&range=01
- incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1529&range=00-01
Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/valhalla/pull/1529.diff
Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1529/head:pull/1529
PR: https://git.openjdk.org/valhalla/pull/1529
More information about the valhalla-dev
mailing list