[lworld] RFR: 8360851: [lworld] missing # {method} comment in assembly dumping [v2]

[Tobias Hartmann]

On Thu, 21 Aug 2025 11:26:54 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> `CodeOffsets::Verified_Inline_Entry` and `CodeOffsets::Verified_Inline_Entry` are special among entry point code offsets because they can be disabled with a value of `-1`. The code installation for hotspot deals with this by just setting both to the same value as `CodeOffsets::Verified_Entry` if they are disabled. JVMCI code installation on the other hand, leaves the offsets at `-1`. When printing the assembly of a JVMCI compiled method where both offsets are disabled, the method name is not printed together with the entry point labels. This is due to the disabled entry points having the lowest address due to their negative offset and those disabled entry points thus pointing to an address before the block that is being printed:
>> 
>> https://github.com/openjdk/valhalla/blob/af03598eb81aee17c0657347fd6439475ca8f7ee/src/hotspot/share/code/nmethod.cpp#L3788-L3796
>> 
>> This PR fixes this issue by checking if the entry points that can be disabled point into the code block that is being printed. The regression test is botched together from two existing tests, due to my inexperience with JVMCI (but it works). Suggestions for a better test are welcome.
>> 
>> Testing:
>>  - [x] tier1,tier2,tier3,valhalla-comp-stress
>
> Manuel Hässig has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Problem list regression test for ZGC on aarch64

Thanks for working on this, Manuel! Fix looks good, just two minor comments.

src/hotspot/share/code/nmethod.cpp line 3792:

> 3790:                      verified_entry_point(),
> 3791:                      inline_entry_point());
> 3792:   if (verified_inline_entry_point() >= block_begin) {

A comment would be good, explaining the special-casing of these two.

test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/MethodTagTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2015, 2025, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.

-------------

Marked as reviewed by thartmann (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1529#pullrequestreview-3150132313
PR Review Comment: https://git.openjdk.org/valhalla/pull/1529#discussion_r2297262309
PR Review Comment: https://git.openjdk.org/valhalla/pull/1529#discussion_r2297257968