[lworld] RFR: 8372113: [lworld] Fix various issues with TypeAryPtr and TypeAryKlassPtr [v6]
Quan Anh Mai
qamai at openjdk.org
Mon Dec 8 12:46:33 UTC 2025
On Mon, 8 Dec 2025 09:56:54 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Should not clone MergeMem
>
> src/hotspot/share/opto/compile.cpp line 1998:
>
>> 1996: if (_inline_type_nodes.length() == 0) {
>> 1997: // keep the graph canonical
>> 1998: igvn.optimize();
>
> Why is this needed?
It is because the other return path canonicalizes the graph, so it makes more sense for this path to do so, too. It is also that analyzing the memory graph in `adjust_flat_array_access_aliases` requires a canonical graph, or else we may encounter an `AddP` that has its type not yet computed.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1755#discussion_r2598486249
More information about the valhalla-dev
mailing list