[lworld] RFR: 8372113: [lworld] Fix various issues with TypeAryPtr and TypeAryKlassPtr [v6]

Tobias Hartmann thartmann at openjdk.org
Tue Dec 16 08:53:34 UTC 2025


On Mon, 15 Dec 2025 11:46:46 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Should we cast it to `InlineTypeNode` in `LibraryCallKit::inline_newArray` instead?
>
> I'm not sure, either. There is this TODO at `LibraryCallKit::inline_newArray`
> 
>     // TODO 8350865 Should we add a check of the init_val type (maybe in debug only + halt)?
> 
> Do you think I should insert a `checkcast` here or leave it as it is for now?

I think a checkcast would be nice if it avoids the check in macro.cpp. We can then add a runtime check with JDK-8350865.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1755#discussion_r2622352976


More information about the valhalla-dev mailing list