[lworld] RFR: 8372113: [lworld] Fix various issues with TypeAryPtr and TypeAryKlassPtr [v6]

Quan Anh Mai qamai at openjdk.org
Mon Dec 15 11:49:53 UTC 2025


On Thu, 11 Dec 2025 14:35:11 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> `LibraryCallKit::inline_newArray` does not type check `init_val`, so if it is untyped (for example, the return value of `Class::new_instance`), then it will not be an `InlineTypeNode`.
>
> Should we cast it to `InlineTypeNode` in `LibraryCallKit::inline_newArray` instead?

I'm not sure, either. There is this TODO at `LibraryCallKit::inline_newArray`

    // TODO 8350865 Should we add a check of the init_val type (maybe in debug only + halt)?

Do you think I should insert a `checkcast` here or leave it as it is for now?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1755#discussion_r2619079799


More information about the valhalla-dev mailing list