[lworld] RFR: 8373622: [lworld] Enabling jimage changes break tests with inMemoryJavaCompiler [v2]

Coleen Phillimore coleenp at openjdk.org
Mon Dec 15 16:43:23 UTC 2025


> This change tests the properties: java.test.opts and the property for test.enable.preview (set when test has @enablePreview), and will pass --enable-preview -source 26 to the inMemoryJavaCompiler compiler task.  I don't really like this but the alternative is to do the same thing from all the tests, and pass this down as parameters.  Better alternative ideas are welcome.
> 
> When the jimage code is checked in, a bunch of tests fail because of this problem.
> 
> Testing with tier1-4.

Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:

  Fix version for javac to be latest version.

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/1797/files
  - new: https://git.openjdk.org/valhalla/pull/1797/files/a0839689..2ae8d25e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=1797&range=01
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1797&range=00-01

  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/valhalla/pull/1797.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1797/head:pull/1797

PR: https://git.openjdk.org/valhalla/pull/1797


More information about the valhalla-dev mailing list