[lworld] RFR: 8373622: [lworld] Enabling jimage changes break tests with inMemoryJavaCompiler [v2]
Chen Liang
liach at openjdk.org
Mon Dec 15 17:06:33 UTC 2025
On Mon, 15 Dec 2025 16:43:23 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> This change tests the properties: java.test.opts and the property for test.enable.preview (set when test has @enablePreview), and will pass --enable-preview -source 26 to the inMemoryJavaCompiler compiler task. I don't really like this but the alternative is to do the same thing from all the tests, and pass this down as parameters. Better alternative ideas are welcome.
>>
>> When the jimage code is checked in, a bunch of tests fail because of this problem.
>>
>> Testing with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix version for javac to be latest version.
lgtm
-------------
Marked as reviewed by liach (Committer).
PR Review: https://git.openjdk.org/valhalla/pull/1797#pullrequestreview-3579256197
More information about the valhalla-dev
mailing list