[lworld] RFR: 8371357: [lworld] Remove EnableValhalla [v3]

Paul Hübner phubner at openjdk.org
Tue Dec 16 10:03:48 UTC 2025


On Mon, 15 Dec 2025 22:11:25 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Paul Hübner has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 23 commits:
>> 
>>  - Use the new function for the Parallel changes.
>>  - Merge branch 'lworld' into JDK-8371357
>>  - Remove wrong comment.
>>  - Fix imports.
>>  - Reviewer comments.
>>  - Copyright.
>>  - Revert "Don't synchronize on Double."
>>    
>>    This reverts commit cbf849c2ce6059af2b43b3dd8cb42445eab4df2b.
>>  - Accidentally changed too many enable_preview.
>>  - Make heap dump test require debug VM.
>>  - Change to arguments.
>>  - ... and 13 more: https://git.openjdk.org/valhalla/compare/8c0c190b...58fb031a
>
> src/hotspot/share/cds/cdsConfig.hpp line 213:
> 
>> 211:     return Arguments::enable_preview() && EnableValhalla;
>> 212:   }
>> 213: 
> 
> Does this file still need to include `arguments.hpp`? I'm not seeing anymore calls into `Arguments::foo`.

Nope, I'll get rid of it.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1759#discussion_r2622602501


More information about the valhalla-dev mailing list