[lworld] RFR: 8374093: [lworld] Cleanup and polish around vgetfield/vputfield [v2]
Joel Sikström
jsikstro at openjdk.org
Fri Dec 19 14:33:13 UTC 2025
> Hello,
>
> I've been looking at the new internal bytecodes vgetfield and vputfield and their callchains from the interpreter down to InlineKlass and have some cleanups. I've not looked at templateTable_x86 so far, only templateTable_aarch64.
>
> Some notes:
> * The `dest_is_initialized` parameter in InlineKlass::write_value_to_addr is `true` for all callers, so I've removed it and inlined `true` to the call to `copy_payload_to_addr`.
> * There seems to be an unnecessary `mark_payload_as_non_null((address)src);` in InlineKlass::copy_payload_to_addr, as the payload should already be non_null if it doesn't match `is_payload_marked_as_null` in the if-statement just above.
>
> Testing:
> * hotspot_valhalla, jdk_valhalla and tier1
Joel Sikström has updated the pull request incrementally with one additional commit since the last revision:
More cleanup
-------------
Changes:
- all: https://git.openjdk.org/valhalla/pull/1840/files
- new: https://git.openjdk.org/valhalla/pull/1840/files/8944d003..e1f1ffa6
Webrevs:
- full: https://webrevs.openjdk.org/?repo=valhalla&pr=1840&range=01
- incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1840&range=00-01
Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod
Patch: https://git.openjdk.org/valhalla/pull/1840.diff
Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1840/head:pull/1840
PR: https://git.openjdk.org/valhalla/pull/1840
More information about the valhalla-dev
mailing list