[lworld] RFR: 8374093: [lworld] Cleanup and polish around vgetfield/vputfield [v2]

[Frederic Parain]

On Fri, 19 Dec 2025 14:33:13 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:

>> Hello,
>> 
>> I've been looking at the new internal bytecodes vgetfield and vputfield and their callchains from the interpreter down to InlineKlass and have some cleanups. I've not looked at templateTable_x86 so far, only templateTable_aarch64.
>> 
>> Some notes:
>> * The `dest_is_initialized` parameter in InlineKlass::write_value_to_addr is `true` for all callers, so I've removed it and inlined `true` to the call to `copy_payload_to_addr`.
>> * There seems to be an unnecessary `mark_payload_as_non_null((address)src);` in InlineKlass::copy_payload_to_addr, as the payload should already be non_null if it doesn't match `is_payload_marked_as_null` in the if-statement just above.
>> 
>> Testing:
>> * hotspot_valhalla, jdk_valhalla and tier1
>
> Joel Sikström has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More cleanup

LGTM.
Thank you for this cleanup.

-------------

Marked as reviewed by fparain (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1840#pullrequestreview-3604693837