[lworld] RFR: 8343846: [lworld] implement spec changes to stack map tables [v2]
Matias Saavedra Silva
matsaave at openjdk.org
Thu Feb 27 21:58:04 UTC 2025
On Thu, 27 Feb 2025 20:31:10 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Typo corrections and method renaming
>
> src/hotspot/share/classfile/stackMapFrame.cpp line 205:
>
>> 203:
>> 204: // Check that assert unset fields are compatible
>> 205: bool compatible = is_unset_fields_compatible(target->assert_unset_fields());
>
> We decided 'is' was more consistent but it does read funny. Maybe verify_unset_fields_are_compatible ?
Maybe `verify_unset_fields_compatibility` works?
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1373#discussion_r1974390671
More information about the valhalla-dev
mailing list