[lworld] RFR: 8343846: [lworld] implement spec changes to stack map tables [v2]

[Matias Saavedra Silva]

On Thu, 27 Feb 2025 20:43:30 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Typo corrections and method renaming
>
> src/hotspot/share/classfile/verifier.cpp line 731:
> 
>> 729:       if (fs.access_flags().is_strict() && !fs.access_flags().is_static()) {
>> 730:         NameAndSig new_field(fs.name(), fs.signature());
>> 731:         strict_fields->put(new_field, new_field);
> 
> For put, you get a pointer back to the new item, so you could save an iteration by having
> 
> if (VerifyNoDebts) {
>    new_field._satisfied = true;
> }
> 
> Or can the value of the hashtable be bool satisfied and the key is NameAndSig ?

I think using bool as the table value might make things a lot cleaner and will save some space so I'll move forward with that if I can. Thanks for the suggestion!

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1373#discussion_r1975952019