[lworld] RFR: 8361082: [lworld] RewriteBytecodesInlineTest fails with SIGSEGV [v3]

[Coleen Phillimore]

On Wed, 2 Jul 2025 21:02:04 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> src/hotspot/share/classfile/systemDictionary.cpp line 1109:
>> 
>>> 1107: 
>>> 1108:   assert(real_k != nullptr, "Sanity check");
>>> 1109:   if (real_k->access_flags().is_identity_class()) {
>> 
>> It looks like you could refactor the check for identity and abstract in to InstanceKlass::check_inline_field(TRAPS) and share the code with ClassFileParser. (?)
>
> This check is being done in Klass so I would need to add it there. I think a better name might be `Klass::check_null_restricted_field(TRAPS)` since these are mandatory conditions for a field to be null restricted. The checks may actually be unnecessary since the `@NullRestricted` annotation can only be used on a concrete value class.

It should be InstanceKlass not Klass though since Klass has no fields.  resolve_with_circularity_check does return an InstanceKlass so the return type should be changed to InstanceKlass.  The check_null_restricted_field name seems good though.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1498#discussion_r2182553605