[lworld] RFR: 8361082: [lworld] RewriteBytecodesInlineTest fails with SIGSEGV [v3]

[Coleen Phillimore]

On Wed, 2 Jul 2025 19:15:43 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Cleanup
>>  - Multilined another log message
>>  - Changed long log messages to multi-line strings
>
> src/hotspot/share/classfile/systemDictionary.cpp line 1195:
> 
>> 1193: 
>> 1194:       if (fs.is_null_free_inline_type()) {
>> 1195:         bool check = preload_from_null_free_field(ik, class_loader, sig, field_index, CHECK_NULL);
> 
> This is a bit confusing that it both has a check for return and CHECK_NULL.  Add a comment that some preloading might fail but not fatally for the shared archive if the class changed in the app.

Can you add comment like:

// A false return means that the class didn't load for other reasons than an exception.

Something like that?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1498#discussion_r2195389138