[lworld] RFR: 8361082: [lworld] RewriteBytecodesInlineTest fails with SIGSEGV [v5]

[Frederic Parain]

On Thu, 3 Jul 2025 20:01:06 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> `RewriteBytecodesInlineTest` fails after # due to a new log message printing the pending exception name even though there may not be a pending exception:
>> `PENDING_EXCEPTION->klass()->name()->as_C_string()`
>> 
>> This patch refactors the loadable descriptor handling used in `SystemDictionary::load_shared_class` to better illustrate how the loadable descriptors property is handled and it corrects the log messages to be consistent with the messages used in the class file parser. Verified with tier 1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Used new method in classfileparser

src/hotspot/share/oops/instanceKlass.cpp line 3594:

> 3592: }
> 3593: 
> 3594: void InstanceKlass::check_null_free_field(Symbol* container_klass_name, TRAPS) {

This method is very misleading, it does nothing related to fields, nor being null-free. And the fact that its name refers to fields but the receiver is the field's type and the container is passed in argument is confusing too, because most methods work the other way around: the receiver is the container, and the arguments tell which fields the query is about.

I'd suggest a static method like that:
can_be_annotated_with_NullRestricted(InstanceKlass* type, Symbol* container_klass_name, TRAPS)

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1498#discussion_r2183678279