[lworld] RFR: 8361082: [lworld] RewriteBytecodesInlineTest fails with SIGSEGV [v5]

[Coleen Phillimore]

On Thu, 3 Jul 2025 20:15:14 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Used new method in classfileparser
>
> src/hotspot/share/oops/instanceKlass.cpp line 3594:
> 
>> 3592: }
>> 3593: 
>> 3594: void InstanceKlass::check_null_free_field(Symbol* container_klass_name, TRAPS) {
> 
> This method is very misleading, it does nothing related to fields, nor being null-free. And the fact that its name refers to fields but the receiver is the field's type and the container is passed in argument is confusing too, because most methods work the other way around: the receiver is the container, and the arguments tell which fields the query is about.
> 
> I'd suggest a static method like that:
> can_be_annotated_with_NullRestricted(InstanceKlass* type, Symbol* container_klass_name, TRAPS)

How about InstanceKlass::check_can_be_null_free_field_type() ? Because it has TRAPS and doesn't return a bool.  And would be nice to not have to have type->access_flags() and type->is_abstract() etc.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1498#discussion_r2183705030