[lworld] RFR: 8361166: [lworld] TestG1BarrierGeneration still fails after JDK-8343420 [v2]

Christian Hagedorn chagedorn at openjdk.org
Mon Jul 7 11:57:52 UTC 2025


On Mon, 7 Jul 2025 09:30:19 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

>> The `TestG1BarrierGeneration::testArrayStore` and `TestG1BarrierGeneration::testArrayStoreTwice` tests are failing with `-XX:-TieredCompilation` because the compilation is inserting a `CastPP` node for the input of the `StoreP` node (due to missing profiling info) and this is restricting the type of the barrier to `notnull`. The test regex checks for exactly `pre post` (nothing after that) and thus fails.
>> This change fixes the test by increasing the warmup iterations for the failing tests.
>> 
>> Tests: Tier 1-3+
>
> Damon Fenacci has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8361166: increase warmup instead of trating -TieredCompilation differently

That's great and looks simpler, thanks!

-------------

Marked as reviewed by chagedorn (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1502#pullrequestreview-2993496245


More information about the valhalla-dev mailing list