[lworld] RFR: 8361166: [lworld] TestG1BarrierGeneration still fails after JDK-8343420 [v2]
Damon Fenacci
dfenacci at openjdk.org
Mon Jul 7 09:30:19 UTC 2025
> The `TestG1BarrierGeneration::testArrayStore` and `TestG1BarrierGeneration::testArrayStoreTwice` tests are failing with `-XX:-TieredCompilation` because the compilation is inserting a `CastPP` node for the input of the `StoreP` node and this is restricting the type of the barrier to `notnull`. The test regex checks for exactly `pre post` (nothing after that) and thus fails.
> This change fixes the test IR rules by restricting the current ones to `-XX:+TieredCompilation` and checking for `pre post notnull` for the `-XX:-TieredCompilation` case.
>
> Tests: Tier 1-3+
Damon Fenacci has updated the pull request incrementally with one additional commit since the last revision:
JDK-8361166: increase warmup instead of trating -TieredCompilation differently
-------------
Changes:
- all: https://git.openjdk.org/valhalla/pull/1502/files
- new: https://git.openjdk.org/valhalla/pull/1502/files/25d00b40..a4617bde
Webrevs:
- full: https://webrevs.openjdk.org/?repo=valhalla&pr=1502&range=01
- incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1502&range=00-01
Stats: 17 lines in 1 file changed: 1 ins; 12 del; 4 mod
Patch: https://git.openjdk.org/valhalla/pull/1502.diff
Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1502/head:pull/1502
PR: https://git.openjdk.org/valhalla/pull/1502
More information about the valhalla-dev
mailing list