[lworld] RFR: 8361166: [lworld] TestG1BarrierGeneration still fails after JDK-8343420

[Damon Fenacci]

On Mon, 7 Jul 2025 07:44:04 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> The `TestG1BarrierGeneration::testArrayStore` and `TestG1BarrierGeneration::testArrayStoreTwice` tests are failing with `-XX:-TieredCompilation` because the compilation is inserting a `CastPP` node for the input of the `StoreP` node (due to missing profiling info) and this is restricting the type of the barrier to `notnull`. The test regex checks for exactly `pre post` (nothing after that) and thus fails.
>> This change fixes the test by increasing the warmup iterations for the failing tests.
>> 
>> Tests: Tier 1-3+
>
> Thanks for working on this! Have you found out why the `CastPP` is inserted without tiered compilation but not with tiered compilation? Are we missing some profiling? In the latter case, you could also try to increase the warm-up iterations and see if that works instead.

Thanks for your review @chhagedorn.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1502#issuecomment-3049002459