[lworld] RFR: 8363846: [lworld] Make Class.isIdentityClass() non-native [v3]

[Coleen Phillimore]

On Wed, 23 Jul 2025 16:43:10 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> test/jdk/valhalla/valuetypes/IsIdentityClassTest.java line 63:
>> 
>>> 61:         RuntimeMXBean runtimeMxBean = ManagementFactory.getRuntimeMXBean();
>>> 62:         List<String> arguments = runtimeMxBean.getInputArguments();
>>> 63:         boolean UseArrayFlattening = !arguments.contains("-XX:-UseArrayFlattening");
>> 
>> Optional comments:
>> 
>> I wonder if it's more usually to obtain flags with serviceability, or explicitly pass -D properties...
>> 
>> Also for these global states, it's better to capture them with a `@Setup static void setup()` method and store in static fields, especially if multiple tests use these states.
>
> I copied this out of a hotspot valhalla test.  If I remove the flattening tests, I suppose I won't need this anymore.

There might be a better way to find this out though.  We use this in the Hotspot runtime valhalla tests, but those tests don't use junit, so @things aren't used.  For Hotspot, we're passing -XX flags for now and not using properties.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1514#discussion_r2226151574