[lworld] RFR: 8363846: [lworld] Make Class.isIdentityClass() non-native [v3]

[Roger Riggs]

On Wed, 23 Jul 2025 15:54:54 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This moves isIdentityClass() implementation to Class.java, and checks within the JVM that is_identity_class() doesn't check the access flags for an ArrayKlass, since AccessFlags aren't initialized in ArrayKlasses.  The AccessFlags should be moved from Klass.hpp to InstanceKlass.cpp in mainline but that's a more complicated change and has several pieces.
>> Added a test.
>> Tested with tier1 locally.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix test to use junit and test without preview mode.

test/jdk/valhalla/valuetypes/IsIdentityClassTest.java line 71:

> 69:         } else {
> 70:             assertFalse(ValueClass.isFlatArray(array0));
> 71:         }

This does not seem to be related to Class.isIdentity(); what is the connection?
Identity or not is not connected to flat or not. Maybe it belongs in a different test.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1514#discussion_r2226067440