[lworld] RFR: 8363846: [lworld] Make Class.isIdentityClass() non-native [v3]

Coleen Phillimore coleenp at openjdk.org
Wed Jul 23 16:51:22 UTC 2025


On Wed, 23 Jul 2025 16:09:36 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix test to use junit and test without preview mode.
>
> test/jdk/valhalla/valuetypes/IsIdentityClassTest.java line 71:
> 
>> 69:         } else {
>> 70:             assertFalse(ValueClass.isFlatArray(array0));
>> 71:         }
> 
> This does not seem to be related to Class.isIdentity(); what is the connection?
> Identity or not is not connected to flat or not. Maybe it belongs in a different test.

With Fred's work for array flattening, I was testing that the array would be flattened.  But we do have other tests for this.  I can remove this part of the test.  I was trying to show that even if we've flattened an Integer array, the array itself is an identityClass.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1514#discussion_r2226139190


More information about the valhalla-dev mailing list