[lworld] RFR: 8336003: [lworld] TestLWorld::test151 triggers "Should have been buffered" assert [v2]

[Quan Anh Mai]

On Mon, 16 Jun 2025 14:46:54 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix dead loop
>
> src/hotspot/share/opto/cfgnode.cpp line 1604:
> 
>> 1602:       Node* phi_in = current->in(i);
>> 1603:       if (phi_in->is_Phi()) {
>> 1604:         visited.append_if_missing(phi_in->as_Phi());
> 
> Would a `Unique_Node_List` be more appropriate here?

`Unique_Node_List` cannot work with `const Node*` so `GrowableArray` is the only option here.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1489#discussion_r2150534984