[lworld] RFR: 8336003: [lworld] TestLWorld::test151 triggers "Should have been buffered" assert [v3]

[Quan Anh Mai]

On Mon, 16 Jun 2025 17:48:26 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> src/hotspot/share/opto/cfgnode.cpp line 1604:
>> 
>>> 1602:       Node* phi_in = current->in(i);
>>> 1603:       if (phi_in->is_Phi()) {
>>> 1604:         visited.append_if_missing(phi_in->as_Phi());
>> 
>> Would a `Unique_Node_List` be more appropriate here?
>
> `Unique_Node_List` cannot work with `const Node*` so `GrowableArray` is the only option here.

Update: Changed it to a `Unique_Node_List`.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1489#discussion_r2151268510