[lworld] RFR: 8351441: [lworld] ClassFile API support generating stack maps for strict field assignment [v5]
Vicente Romero
vromero at openjdk.org
Mon Mar 10 22:43:09 UTC 2025
On Mon, 10 Mar 2025 20:04:41 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Works for a basic case, running tests, need more tests to ensure other features added in this patch
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>
> Move test to classfile
src/java.base/share/classes/jdk/internal/classfile/impl/WritableField.java line 82:
> 80: if (sizeOne != sizeTwo)
> 81: return true;
> 82: for (int i = 0; i < sizeOne; i++) {
there could be a mismatch even if both arrays have the same length and same content but the order of the fields is different in each array, not sure if this could happen but we should consider it
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1392#discussion_r1988116361
More information about the valhalla-dev
mailing list