[lworld] RFR: 8351441: [lworld] ClassFile API support generating stack maps for strict field assignment [v5]

[Chen Liang]

On Mon, 10 Mar 2025 22:40:20 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move test to classfile
>
> src/java.base/share/classes/jdk/internal/classfile/impl/WritableField.java line 82:
> 
>> 80:             if (sizeOne != sizeTwo)
>> 81:                 return true;
>> 82:             for (int i = 0; i < sizeOne; i++) {
> 
> there could be a mismatch even if both arrays have the same length and same content but the order of the fields is different in each array, not sure if this could happen but we should consider it

Originally this matches because I am only removing unsets. Now Dan told me that we need to consider adding more to unset fields if we have loops, so I will do a sort for the arrays to ensure they have some definite order.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1392#discussion_r1988126697