[lworld] RFR: 8354408: [lworld] compiler/types/TestSubTypeCheckUniqueSubclass.java IR mismatches post jdk-25+16 merge

Christian Hagedorn chagedorn at openjdk.org
Mon May 5 08:02:03 UTC 2025


On Thu, 1 May 2025 05:10:33 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

> Hi,
> 
> The issue here is that `IRNode::macroNodes` takes a full line regex, not only the node name part like `IRNode::beforeMatchingNameRegex`. As a result, we should compute the full regex for `SUBTYPE_CHECK`.
> 
> Please kindly review, thanks a lot.

test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java line 1974:

> 1972:     static {
> 1973:         String regex = START + "SubTypeCheck" + MID + END;
> 1974:         macroNodes(SUBTYPE_CHECK, regex);

Could you also directly call `beforeMatchingNameRegex()` as we do in mainline?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1448#discussion_r2073005121


More information about the valhalla-dev mailing list