[lworld] RFR: 8354408: [lworld] compiler/types/TestSubTypeCheckUniqueSubclass.java IR mismatches post jdk-25+16 merge

[Quan Anh Mai]

On Mon, 5 May 2025 07:59:05 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Hi,
>> 
>> The issue here is that `IRNode::macroNodes` takes a full line regex, not only the node name part like `IRNode::beforeMatchingNameRegex`. As a result, we should compute the full regex for `SUBTYPE_CHECK`.
>> 
>> Please kindly review, thanks a lot.
>
> test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java line 1974:
> 
>> 1972:     static {
>> 1973:         String regex = START + "SubTypeCheck" + MID + END;
>> 1974:         macroNodes(SUBTYPE_CHECK, regex);
> 
> Could you also directly call `beforeMatchingNameRegex()` as we do in mainline?

I believe you changed it to `macroNodes` here :)

https://github.com/openjdk/valhalla/pull/1296

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1448#discussion_r2073043237