[lworld] RFR: 8354408: [lworld] compiler/types/TestSubTypeCheckUniqueSubclass.java IR mismatches post jdk-25+16 merge

[Christian Hagedorn]

On Mon, 5 May 2025 08:29:26 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java line 1974:
>> 
>>> 1972:     static {
>>> 1973:         String regex = START + "SubTypeCheck" + MID + END;
>>> 1974:         macroNodes(SUBTYPE_CHECK, regex);
>> 
>> Could you also directly call `beforeMatchingNameRegex()` as we do in mainline?
>
> I believe you changed it to `macroNodes` here :)
> 
> https://github.com/openjdk/valhalla/pull/1296

Okay, I guess it makes sense to treat it as macro node here to limit the compile phases. We should probably also change that in mainline but probably not worth to do it separately in mainline.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1448#discussion_r2073077311