[lworld] RFR: 8335256: [lworld] C2: Remove larval InlineTypeNode [v5]

[Quan Anh Mai]

On Fri, 9 May 2025 07:26:48 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - move progress check
>>  - Merge branch 'lworld' into larvaloop
>>  - fast path for non intrinsics
>>  - fix test failures
>>  - Merge branch 'lworld' into larvaloop
>>  - remove larval InlineTypeNode
>
> src/hotspot/share/opto/compile.cpp line 2847:
> 
>> 2845: 
>> 2846:   {
>> 2847:     // Eliminate some macro nodes before EA to reduce analysis pressure
> 
> Is this something we should consider doing in mainline?

I'm not sure what effect it will have on mainline. For this patch, without this, `TestNullableInlineTypes::test85` tries to enter EA with 10k nodes, which it bails out. Trying to eliminate all trivially removable allocations reduces the number to 2k, allows EA to complete successfully. I think it may be more significant on Valhalla because in general we seem to emit a lot more nodes with value objects.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1447#discussion_r2082243176