[lworld] RFR: 8335256: [lworld] C2: Remove larval InlineTypeNode [v5]

Quan Anh Mai qamai at openjdk.org
Fri May 9 18:13:09 UTC 2025


On Fri, 9 May 2025 18:04:30 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> src/hotspot/share/opto/compile.cpp line 2847:
>> 
>>> 2845: 
>>> 2846:   {
>>> 2847:     // Eliminate some macro nodes before EA to reduce analysis pressure
>> 
>> Is this something we should consider doing in mainline?
>
> I'm not sure what effect it will have on mainline. For this patch, without this, `TestNullableInlineTypes::test85` tries to enter EA with 10k nodes, which it bails out. Trying to eliminate all trivially removable allocations reduces the number to 2k, allows EA to complete successfully. I think it may be more significant on Valhalla because in general we seem to emit a lot more nodes with value objects.

Please let me know what you think about this, perhaps we need to measure the effects on mainline first.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1447#discussion_r2082250108


More information about the valhalla-dev mailing list