[lworld] RFR: 8335256: [lworld] C2: Remove larval InlineTypeNode [v5]

[Tobias Hartmann]

On Fri, 9 May 2025 17:56:35 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> src/hotspot/share/opto/inlinetypenode.cpp line 1100:
>> 
>>> 1098:   Node* base = is_loaded(phase);
>>> 1099:   if (base != nullptr && !base->is_InlineType() && !phase->type(base)->maybe_null() && AllocateNode::Ideal_allocation(base) == nullptr) {
>>> 1100:     if (oop != base || phase->type(is_buffered) != TypeInt::ONE) {
>> 
>> Maybe use `InlineTypeNode::is_allocated` here instead?
>
> `InlineTypeNode::is_allocated` tries to see if an `InlineTypeNode` is buffered, while this check tries to see if the node has `is_buffered` being `true` and `oop` being exactly `base`, not a random value. So it cannot be used here.

Right, thanks for the clarification.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1447#discussion_r2084510165