[lworld] RFR: 8335256: [lworld] C2: Remove larval InlineTypeNode [v6]

[Quan Anh Mai]

On Fri, 9 May 2025 09:17:33 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Tobias' comments
>
> src/hotspot/share/opto/inlinetypenode.cpp line 1492:
> 
>> 1490:     res->set_oop(kit->gvn(), alloc_oop);
>> 1491:   }
>> 1492:   // TODO 8239003
> 
> Should we close/update [JDK-8239003](https://bugs.openjdk.org/browse/JDK-8239003) now?

I think we can.

> src/hotspot/share/opto/inlinetypenode.cpp line 1741:
> 
>> 1739: // Equivalent InlineTypeNodes are merged by GVN, so we just need to search for AllocateNode users to find redundant allocations.
>> 1740: void InlineTypeNode::remove_redundant_allocations(PhaseIdealLoop* phase) {
>> 1741:   // TODO 8332886 Really needed? GVN is disabled anyway.
> 
> Should [JDK-8332886](https://bugs.openjdk.org/browse/JDK-8332886) be updated? Can the tests marked with `// TODO 8332886` in `TestBasicFunctionality.java` be enabled again?

I tried and the `TODO` on `test28` can go away while that on `test21` cannot. I have not investigated further. The caption of [JDK-8332886](https://bugs.openjdk.org/browse/JDK-8332886) should certainly be updated after this patch, though.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1447#discussion_r2082236372
PR Review Comment: https://git.openjdk.org/valhalla/pull/1447#discussion_r2082235655