[lworld] RFR: 8335256: [lworld] C2: Remove larval InlineTypeNode [v6]

Tobias Hartmann thartmann at openjdk.org
Mon May 12 11:58:06 UTC 2025


On Fri, 9 May 2025 17:57:54 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> src/hotspot/share/opto/inlinetypenode.cpp line 1741:
>> 
>>> 1739: // Equivalent InlineTypeNodes are merged by GVN, so we just need to search for AllocateNode users to find redundant allocations.
>>> 1740: void InlineTypeNode::remove_redundant_allocations(PhaseIdealLoop* phase) {
>>> 1741:   // TODO 8332886 Really needed? GVN is disabled anyway.
>> 
>> Should [JDK-8332886](https://bugs.openjdk.org/browse/JDK-8332886) be updated? Can the tests marked with `// TODO 8332886` in `TestBasicFunctionality.java` be enabled again?
>
> I tried and the `TODO` on `test28` can go away while that on `test21` cannot. I have not investigated further. The caption of [JDK-8332886](https://bugs.openjdk.org/browse/JDK-8332886) should certainly be updated after this patch, though.

Sounds good, please update [JDK-8332886](https://bugs.openjdk.org/browse/JDK-8332886) accordingly once this is in.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1447#discussion_r2084512511


More information about the valhalla-dev mailing list