[lworld] RFR: 8372038: [lworld] Update ExplodedImage to use preview mode correctly
Roger Riggs
rriggs at openjdk.org
Tue Nov 25 20:11:29 UTC 2025
On Tue, 18 Nov 2025 00:10:39 GMT, David Beaumont <duke at openjdk.org> wrote:
> Adds preview mode support for ExplodedImage.
>
> Adds tests so both ExplodedImage and ImageReader implementations of SystemImage are tested with exactly the same test data and assertions.
Looks good.
src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java line 157:
> 155: }
> 156: }
> 157: collectChildNodes(modulesDir.resolve(relPath), list);
This merges the preview files with the normal files; does that result in any duplicates?
-------------
Marked as reviewed by rriggs (Committer).
PR Review: https://git.openjdk.org/valhalla/pull/1743#pullrequestreview-3506226573
PR Review Comment: https://git.openjdk.org/valhalla/pull/1743#discussion_r2560922697
More information about the valhalla-dev
mailing list