[lworld] RFR: 8372038: [lworld] Update ExplodedImage to use preview mode correctly
David Beaumont
duke at openjdk.org
Wed Nov 26 11:17:16 UTC 2025
On Tue, 25 Nov 2025 17:55:03 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Adds preview mode support for ExplodedImage.
>>
>> Adds tests so both ExplodedImage and ImageReader implementations of SystemImage are tested with exactly the same test data and assertions.
>
> src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java line 157:
>
>> 155: }
>> 156: }
>> 157: collectChildNodes(modulesDir.resolve(relPath), list);
>
> This merges the preview files with the normal files; does that result in any duplicates?
Well spotted, thanks. That should be filtering existing preview versions out.
I fixed the test so it would spot this issue.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1743#discussion_r2564575706
More information about the valhalla-dev
mailing list