[lworld] RFR: 8372038: [lworld] Update ExplodedImage to use preview mode correctly [v2]
David Beaumont
duke at openjdk.org
Wed Nov 26 13:10:22 UTC 2025
On Wed, 26 Nov 2025 11:14:44 GMT, David Beaumont <duke at openjdk.org> wrote:
>> src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java line 157:
>>
>>> 155: }
>>> 156: }
>>> 157: collectChildNodes(modulesDir.resolve(relPath), list);
>>
>> This merges the preview files with the normal files; does that result in any duplicates?
>
> Well spotted, thanks. That should be filtering existing preview versions out.
> I fixed the test so it would spot this issue.
After looking back at the code I also did a slight tidy up (no need to store nodes in directories, names will suffice and it makes the collect code a bit more idiomatic.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1743#discussion_r2564929625
More information about the valhalla-dev
mailing list