[lworld] RFR: 8370450: [lworld] Alternate implementation of the substitutability test method [v2]

Frederic Parain fparain at openjdk.org
Fri Oct 24 15:05:13 UTC 2025


On Thu, 23 Oct 2025 18:04:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Frederic Parain has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>> 
>>  - Merge remote-tracking branch 'upstream/lworld' into new_acmp
>>  - Add alternate version of the substitutability method
>
> src/hotspot/share/classfile/classFileParser.cpp line 5546:
> 
>> 5544:     // Current format of acmp maps:
>> 5545:     // All maps are stored contiguously in a single int array because it might
>> 5546:     // be to early to instantiate an Object array (to be investigated)
> 
> Suggestion:
> 
>     // be to early too instantiate an Object array (to be investigated)

Fixed

> src/hotspot/share/prims/unsafe.cpp line 970:
> 
>> 968: 
>> 969:   if (!k->is_inline_klass()) {
>> 970:         THROW_MSG_NULL(vmSymbols::java_lang_IllegalArgumentException(), "Argument is not a concrete value class");
> 
> Suggestion:
> 
>     THROW_MSG_NULL(vmSymbols::java_lang_IllegalArgumentException(), "Argument is not a concrete value class");

Fixed

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1695#discussion_r2460925463
PR Review Comment: https://git.openjdk.org/valhalla/pull/1695#discussion_r2460923613


More information about the valhalla-dev mailing list