[lworld] RFR: 8370450: [lworld] Alternate implementation of the substitutability test method [v2]

[Frederic Parain]

On Thu, 23 Oct 2025 20:26:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Frederic Parain has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>> 
>>  - Merge remote-tracking branch 'upstream/lworld' into new_acmp
>>  - Add alternate version of the substitutability method
>
> src/hotspot/share/classfile/fieldLayoutBuilder.cpp line 1303:
> 
>> 1301:   int start = map->adr_at(last_idx)->first > offset ? 0 : last_idx;
>> 1302:   bool inserted = false;
>> 1303:   for (int c = start; c < map->length() && !inserted ; c++) {
> 
> You don't need to check inserted in this for loop because you have breaks, if I'm reading this right.

Correct. It's a remain of a previous version where there was two nested loops and break couldn't be used.
Fixed

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1695#discussion_r2461709179