[lworld] RFR: 8370217: [lworld] Crash in add_migrated_value_classes after merging JDK-8350550 [v2]

[Coleen Phillimore]

On Tue, 28 Oct 2025 19:31:16 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> The method add_migrated_value_classes() is being called in non-preview mode leading to an assert due to the expected classes not being present in the AOT cache. The check for `EnableValhalla` is replaced with a check for preview mode. Verified with tier 1-5 tests.
>
> Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Coleen comments
>  - Merge branch 'lworld' into crash_8370217
>  - 8370217: [lworld] Crash in add_migrated_value_classes after merging JDK-8350550

Looks good!  Small nit though, maybe EnableValhalla should be before Arguments::enable_preview() since that's the pattern in the rest of the code that we're going to be looking for when we figure out how to resolve this option (remove or keep).

-------------

Marked as reviewed by coleenp (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1698#pullrequestreview-3393045926