[lworld] RFR: 8370217: [lworld] Crash in add_migrated_value_classes after merging JDK-8350550 [v2]

Matias Saavedra Silva matsaave at openjdk.org
Wed Oct 29 15:52:49 UTC 2025


On Wed, 29 Oct 2025 12:22:07 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> Looks good! Small nit though, maybe EnableValhalla should be before Arguments::enable_preview() since that's the pattern in the rest of the code that we're going to be looking for when we figure out how to resolve this option (remove or keep).

I'm not sure what you mean by this since the other cases that check for preview and valhalla are in this order:
`Arguments::enable_preview() && EnableValhalla`

You can see that pattern in cdsConfig and arguments.cpp.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1698#issuecomment-3462394144


More information about the valhalla-dev mailing list