[lworld] RFR: 8370217: [lworld] Crash in add_migrated_value_classes after merging JDK-8350550 [v2]
Matias Saavedra Silva
matsaave at openjdk.org
Wed Oct 29 19:26:15 UTC 2025
On Wed, 29 Oct 2025 12:22:07 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Coleen comments
>> - Merge branch 'lworld' into crash_8370217
>> - 8370217: [lworld] Crash in add_migrated_value_classes after merging JDK-8350550
>
> Looks good! Small nit though, maybe EnableValhalla should be before Arguments::enable_preview() since that's the pattern in the rest of the code that we're going to be looking for when we figure out how to resolve this option (remove or keep).
Thanks for the reviews @coleenp and @fparain!
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1698#issuecomment-3463459058
More information about the valhalla-dev
mailing list