[lworld] RFR: 8366705: [lworld] Re-work of arrays meta-data [v4]

[Frederic Parain]

On Wed, 3 Sep 2025 16:33:04 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Frederic Parain has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 67 commits:
>> 
>>  - Merge branch 'array_klasses' of github.com:fparain/valhalla into array_klasses
>>  - Forgot a TODO
>>  - Small cleanup
>>  - Merge remote-tracking branch 'upstream/lworld' into array_klasses
>>  - Moved get_Klass() back to protected and updated usages
>>  - Merge branch 'array_klasses' of github.com:fparain/valhalla into array_klasses
>>  - Linked TODOs to JDK-8366668
>>  - Multidim array fix
>>  - Cleanup T_FLAT_ELEMENT related code
>>  - Fix for isAssignableFrom + tests
>>  - ... and 57 more: https://git.openjdk.org/valhalla/compare/22e9d5f5...527a17b6
>
> src/hotspot/share/classfile/javaClasses.cpp line 1485:
> 
>> 1483: void java_lang_Class::release_set_array_klass(oop java_class, Klass* klass) {
>> 1484:   assert(klass->is_klass() && klass->is_array_klass(), "should be array klass");
>> 1485:   assert(!klass->is_refArray_klass() && !klass->is_flatArray_klass(), "should not be ref or flat array klass");
> 
> Suggestion:
> 
>   assert(!klass->is_refined_objArray_klass(), "should not be ref or flat array klass");
> 
> 
> Hope that's right.

Fixed.

> src/hotspot/share/oops/arrayKlass.cpp line 174:
> 
>> 172:       // Create multi-dim klass object and link them together
>> 173:       ObjArrayKlass* ak = nullptr;
>> 174:       ak = RefArrayKlass::allocate_objArray_klass(class_loader_data(), dim + 1, this, CHECK_NULL);
> 
> Can you make this one line?

Sure. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1452#discussion_r2323312709
PR Review Comment: https://git.openjdk.org/valhalla/pull/1452#discussion_r2323316189