[lworld] RFR: 8366705: [lworld] Re-work of arrays meta-data [v4]
Frederic Parain
fparain at openjdk.org
Fri Sep 5 11:57:30 UTC 2025
On Wed, 3 Sep 2025 16:58:44 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Frederic Parain has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 67 commits:
>>
>> - Merge branch 'array_klasses' of github.com:fparain/valhalla into array_klasses
>> - Forgot a TODO
>> - Small cleanup
>> - Merge remote-tracking branch 'upstream/lworld' into array_klasses
>> - Moved get_Klass() back to protected and updated usages
>> - Merge branch 'array_klasses' of github.com:fparain/valhalla into array_klasses
>> - Linked TODOs to JDK-8366668
>> - Multidim array fix
>> - Cleanup T_FLAT_ELEMENT related code
>> - Fix for isAssignableFrom + tests
>> - ... and 57 more: https://git.openjdk.org/valhalla/compare/22e9d5f5...527a17b6
>
> src/hotspot/share/oops/objArrayKlass.cpp line 122:
>
>> 120: bk = ObjArrayKlass::cast(element_klass)->bottom_klass();
>> 121: } else if (element_klass->is_flatArray_klass()) {
>> 122: bk = FlatArrayKlass::cast(element_klass)->element_klass(); // flat array case should be merge with refArray case once reparented
>
> TODO? Not sure what this means. FlatArrayKlass inherits from ObjArrayKlass in your patch, so this is done?
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1452#discussion_r2324894787
More information about the valhalla-dev
mailing list