[lworld] RFR: 8366270: [lworld] Fix ClassFile AccessFlagsTest [v2]

Vicente Romero vromero at openjdk.org
Wed Feb 4 21:18:08 UTC 2026


On Wed, 4 Feb 2026 19:01:37 GMT, Chen Liang <liach at openjdk.org> wrote:

>> When we read a class file and decode the access flag, we should use the class file's version to decode the flag, so we won't get spurious SUPER and IDENTITY mismatches.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Fix version parse bug, improve coverage
>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into fix/accessflags-pass-cffv
>  - 8366270

src/java.base/share/classes/jdk/internal/classfile/impl/ClassReaderImpl.java line 161:

> 159:     }
> 160: 
> 161:     public int classFileVersion() {

shouldn't this method be declared in ClassReader and overridden here?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/2036#discussion_r2766001274


More information about the valhalla-dev mailing list